Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation based on glossary with deepl-node doesnt work #52

Open
meierdean opened this issue Aug 5, 2024 · 1 comment
Open

Translation based on glossary with deepl-node doesnt work #52

meierdean opened this issue Aug 5, 2024 · 1 comment

Comments

@meierdean
Copy link

meierdean commented Aug 5, 2024

Describe the bug
With the npm package "deepl-node" it is not possible to make translations based on a glossary.
It works with a normal fetch instead of using the library.

To Reproduce
Steps to reproduce the behavior:

  1. install the npm-package "deepl-node"
  2. add a glossary to deepl
  3. use the function "translateText" with an existing glossaryId

Expected behavior
The glossary should be included when translating and the resulted translation should contain the defined word from the glossary.

@JanEbbing
Copy link
Member

JanEbbing commented Aug 5, 2024

Hi, what exactly does not work about this? Do you get an error? is the glossary not applied? We have a test covering this use case and I cannot reproduce this locally.

I checked with const result = await translator.translateText('That is hot', 'EN', targetLang, {glossary: '0a6c701e-303a-41ba-a167-857c5b720a4c'});

which is translated to "Das ist heiß" without a glossary and "Das ist scharf" with a glossary that maps 'hot' => 'scharf'.

Edit: On deepl-node v1.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants