Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job requirements should be moved from job prototypes #1973

Open
MilonPL opened this issue Oct 5, 2024 · 1 comment
Open

job requirements should be moved from job prototypes #1973

MilonPL opened this issue Oct 5, 2024 · 1 comment
Labels
Good First Issue Good issue for a new contributor to try fixing. Priority: 4-Low Should be resolved at some point

Comments

@MilonPL
Copy link
Member

MilonPL commented Oct 5, 2024

Description

Job requirements should be moved away from JobPrototypes and synced with upstream (less conflicts, yippee) into the JobRequirementOverridePrototype. Sounds hard but it's actually all yaml, so it's a good first issue.
Basically you need to create a new requirement_overrides.yml in the DeltaV namespace and then update the deltav.toml file to include role_timer_override = DeltaV under [game]

Example:

- type: jobRequirementOverride
  id: DeltaV
  jobs:
    HeadOfSecurity:
    - !type:DepartmentTimeRequirement
      department: Security
      time: 72000 # 20 hours
    - !type:RoleTimeRequirement
      role: JobWarden
      time: 36000 # 10 hours
    - !type:DepartmentTimeRequirement 
      department: Command
      time: 36000 # 10 hours
    - !type:OverallPlaytimeRequirement
      time: 90000 # 25 hours
@github-actions github-actions bot added the S: Untriaged This issue or PR needs labelling label Oct 5, 2024
@MilonPL MilonPL added Priority: 4-Low Should be resolved at some point Good First Issue Good issue for a new contributor to try fixing. and removed S: Untriaged This issue or PR needs labelling labels Oct 5, 2024
@Brijeshthummar02

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good issue for a new contributor to try fixing. Priority: 4-Low Should be resolved at some point
Projects
None yet
Development

No branches or pull requests

2 participants