Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DV/Nyano based lights need to display properly while mapping. [Beginner Friendly] #2240

Open
IamVelcroboy opened this issue Nov 19, 2024 · 0 comments
Open

DV/Nyano based lights need to display properly while mapping. [Beginner Friendly] #2240

IamVelcroboy opened this issue Nov 19, 2024 · 0 comments
Labels
Changes: YML Changes any yml files Good First Issue Good issue for a new contributor to try fixing. Priority: 3-Medium Needs to be resolved at some point

Comments

@IamVelcroboy
Copy link
Member

Description

Upstream lights work as they should but ours were never updated. They need their light values attached to the structure to properly display we while mapping. Easy beginner PR.

Reproduction
Map lights from upstream. Map lights from our base. Compare.

Screenshots
N/A

Additional context
N/A
@deltanedas deltanedas added Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Good First Issue Good issue for a new contributor to try fixing. and removed Status: Untriaged labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Changes: YML Changes any yml files Good First Issue Good issue for a new contributor to try fixing. Priority: 3-Medium Needs to be resolved at some point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deltanedas @IamVelcroboy