Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include rainfall in spw files #392

Closed
2 tasks done
GundulaW opened this issue Mar 18, 2024 · 2 comments · Fixed by #443
Closed
2 tasks done

Include rainfall in spw files #392

GundulaW opened this issue Mar 18, 2024 · 2 comments · Fixed by #443
Assignees
@GundulaW
Labels
Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised

Comments

@GundulaW
Copy link
Contributor

FloodAdapt version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of FloodAdapt.

Reproducible Example

Rainfall is never added in spiderweb files

Current behaviour

Rainfall is never added in spiderweb files

Desired behaviour

Add rainfall if rainfall_source is track

Task list

fix

Additional context

No response
@GundulaW GundulaW added Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised labels Mar 18, 2024
@GundulaW GundulaW self-assigned this Mar 18, 2024
@dladrichem
Copy link
Contributor

Check if it is aleady fixed. If so, close issue

@GundulaW GundulaW linked a pull request May 16, 2024 that will close this issue
include rainfall in spw file if rainfall from track is chosen #443
Merged
@GundulaW
Copy link
Contributor Author

Left with rainfall from track, right without
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GundulaW GundulaW

Labels
Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include rainfall in spw file if rainfall from track is chosen Deltares-research/FloodAdapt
2 participants
@GundulaW @dladrichem