Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong volume when importing GreenInfra polygons from file #441

Closed
3 tasks done
GundulaW opened this issue May 15, 2024 · 0 comments · Fixed by #442
Closed
3 tasks done

Wrong volume when importing GreenInfra polygons from file #441

GundulaW opened this issue May 15, 2024 · 0 comments · Fixed by #442
Assignees
@GundulaW
Labels
Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised

Comments

@GundulaW
Copy link
Contributor

GundulaW commented May 15, 2024 •
edited
Loading

FloodAdapt version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of FloodAdapt.

Reproducible Example

When importing multiple polygons for GreenInfra from file the total volume is too small.

Current behaviour

green_infrastructure.calculate_polygon_area only calculates the area of the first polygon and not the total area of all polygons.

Desired behaviour

It should use the total area of all polygons

Task list

  • calculate total area of all polygons

Additional context

No response
@GundulaW GundulaW added Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised labels May 15, 2024
@GundulaW GundulaW self-assigned this May 15, 2024
@GundulaW GundulaW linked a pull request May 15, 2024 that will close this issue
total area of all polygons from imported file #442
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GundulaW GundulaW

Labels
Bug Something isn't working Needs refinement Issues that still need to be discusses, made more concrete or prioritised
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

total area of all polygons from imported file Deltares-research/FloodAdapt
1 participant
@GundulaW