Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pypi package dependency #488

Open
2 tasks
dladrichem opened this issue Jul 12, 2024 · 4 comments
Open
2 tasks

Pypi package dependency #488

dladrichem opened this issue Jul 12, 2024 · 4 comments
Assignees
Labels
beta release Feature New feature request Needs refinement Issues that still need to be discusses, made more concrete or prioritised

Comments

@dladrichem
Copy link
Contributor

Kind of request

Changing existing functionality

Enhancement Description

Now, all dependencies that we could publish are on pypi. This is very usefull for installing by users, but in case you want to change something in a dependecy, this means that you have to make a new release every time you want to test this in teamcity. For example, now I changed the metrics parsing in fiat_toolbox. This change was linked to a change in FloodAdapt, which could only be tested and then merged if there was a new release of the fiat_toolbox. There should be an easier way to do this

Task list

  • Think of something better
  • Do this

Use case

No response

Additional Context

No response

@dladrichem dladrichem added Feature New feature request Needs refinement Issues that still need to be discusses, made more concrete or prioritised labels Jul 12, 2024
@savente93 savente93 added Backend and removed Backend labels Jul 22, 2024
@kathrynroscoe
Copy link
Contributor

Old colleague is owner of two CHT packages, so now we can not make these packages open.

We want to create new repos for these so we can put them on pypi, and then we just don't touch those old ones anymore. Need to alert everyone in Deltares who uses these repos.

@savente93
Copy link
Contributor

Can we update the packages to include a deprecation warning?

@LuukBlom
Copy link
Contributor

Just called Sar and he has asked pypi to change the email associated with his account
when pypi does this, he will transfer ownership of the problematic packages to me.

So we are currently waiting on pypi again, I will regularly check the issue to see if anything happened. pypi/support#4055

@LuukBlom
Copy link
Contributor

LuukBlom commented Dec 18, 2024

The problematic repos for FA are:

cht_observations
cht_meto
cht_tide
cht_cyclones

I wrote a workflow that creates a release (on gh and pypi) when a tag is pushed that matches: v*.*.*, which is already working and in the main branch of fiat_toolbox.
I have created PR's in the repos where Im waiting on Sarwan.
When I get ownership of Sarwan's packages, I'll add them as trusted publishers and merge the PR's.

When that is done, the way of working when changing stuff in FA dependencies will be:

  1. make the changes locally (editable install of the repo)

  2. run tests (of the repo and of FA)

  3. if all green -> make PR

  4. review + implement comments

  5. LGTM -> merge to main (Now we have the new changes in main)

  6. increase version in init.py (and merge to main as well)

  7. create a tag (git tag v1.2.3)

  8. push the tag to remote (git push origin tag v1.2.3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta release Feature New feature request Needs refinement Issues that still need to be discusses, made more concrete or prioritised
Projects
None yet
Development

No branches or pull requests

5 participants