Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neater timezone handling and time corrections in calc_havengetallen #162

Closed
veenstrajelmer opened this issue Oct 23, 2024 · 0 comments · Fixed by #163
Closed

neater timezone handling and time corrections in calc_havengetallen #162

veenstrajelmer opened this issue Oct 23, 2024 · 0 comments · Fixed by #163

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 23, 2024

We added tz_localize on 29-5-2024 (#30), this means we pass a UTC+1 timeseries as if it were a UTC timeseries. In Deltares/hatyan#333 timezone support was added to astrog. Therefore, we can now conveniently use timezones here also.

So, handle timezones more cleanly, e.g. by not correcting for 1 hour difference in culm_addtime and at the same time dropping a timezone

@veenstrajelmer veenstrajelmer linked a pull request Oct 23, 2024 that will close this issue
This was referenced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant