Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass complete measurement series throughout code #166

Closed
3 tasks done
veenstrajelmer opened this issue Oct 24, 2024 · 0 comments · Fixed by #168
Closed
3 tasks done

pass complete measurement series throughout code #166

veenstrajelmer opened this issue Oct 24, 2024 · 0 comments · Fixed by #168

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 24, 2024

Troughout the KWK_process.py example script there are timeseries used with different start/stop times. Instead pass todate timeseries everywhere and make sure that some functions only use the last 10/19 years.

Todo:

  • pass df_meas_todate and df_ext_12_todate to all functions and take last 10 years of timeseries if function requires this instead
  • add test for new function
  • also raise error/warning if e.g. 4 years is provided instead of 10 years? Maybe fine to hard-code expected number of years, but only if we make the mean value/time computation a modular function. This would require update some of the tests >> for now only added a warning if the resulting amount of years is less than requested.
@veenstrajelmer veenstrajelmer changed the title correct havengetallen with slotgemiddelden pass complete measurement series throughout code Oct 25, 2024
@veenstrajelmer veenstrajelmer linked a pull request Oct 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant