Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overschrijdingsfrequenties #80

Open
2 of 9 tasks
veenstrajelmer opened this issue Jun 20, 2024 · 0 comments
Open
2 of 9 tasks

Improve overschrijdingsfrequenties #80

veenstrajelmer opened this issue Jun 20, 2024 · 0 comments

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jun 20, 2024

Todo 2024:

Todo 2025:

  • Optional data corrections #29
  • Exceedance frequencies for 2011 differ from reference dataset #154
  • Link to Python API for HYDRA exceedance frequencies #155
  • in gecombineerd line, which should be last measurement freq and first hydra freq? >> varied dependending on n-years of measurements per station before
  • simplify rule_type and rule_value parameters, but keep in mind other applications
  • threshold for river discharge was disabled in calc_overschrijding(). Disabling this makes it more generic and suitable for coastal stations, but it has negative impact for benedenrivierengebied stations.
  • many functions are not used, sometimes because there are multiple alternatives (hkv and non-hkv). Choose which functions to keep (and increase code coverage+assertions) and remove the rest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant