Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create toplevel io.rr tree structure for RainfallRunoffModel input #168

Closed
arthurvd opened this issue Dec 8, 2021 · 0 comments · Fixed by #235
Closed

Create toplevel io.rr tree structure for RainfallRunoffModel input #168

arthurvd opened this issue Dec 8, 2021 · 0 comments · Fixed by #235
Labels
type: enhancement Improvements to existing functionality

Comments

@arthurvd
Copy link
Member

arthurvd commented Dec 8, 2021

Current tree structure under hydrolib.core.io is now a mixture of many FM (sub)files, DIMR, and a few RR (sub)files.
Let's improve it as follows:

  • hydrolib/core/io/
    • rr/: all RR_related files
      • models.py: with the RainfallRunoffModel and its toplevel components (currently none), and references to child models.
        Note: this means that the 'fnm/' dir will disappear.
      • meteo/: rainfall and other meteo files
        • here the contents of the current 'io/bui/' dir.
      • topology/: Topology layer (node + link file, see D.19.13 in https://content.oss.deltares.nl/delft3d/manuals/SOBEK_User_Manual.pdf#subsection.D.19.13 )
        This was now called 'rr/network/' in branch feature/138_add_rr_network_topology_node_file
        • models.py: with the Node and Link models together.
      • in the future, more subdirs under 'rr/' may appear, for example 'boundary/', 'paved', etc. (See subsections D.19 in SOBEK UM)
        Note: this part of the work under other future issue.
    • fm/: all FM related files
      Note: this part of the work under other future issue/
    • dimr/ all DIMR related files
      Note: this part of the work under other future issue/

In addition to this directory reorganization, also some additional work in this same issue:

  • hook up the current Node and Link model classes into the RainfallRunoffModel.node_data and .branch_data attributes.
  • Add a root validator to RainfallRunoffModel that checks for all branch data links whether their start and end node id is present in the node_data nodes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant