You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the request
When using a url as an input path, this error is raised "OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\DATA\\dfm_tools\\tests\\examples\\https:\\raw.githubusercontent.com\\Deltares\\HYDROLIB-core\\main\\tests\\data\\input\\dflowfm_individual_files\\with_optional_sections.mdu'"
To Reproduce
import hydrolib.core.dflowfm as hcdfm
file_mdu = 'https://raw.githubusercontent.com/Deltares/HYDROLIB-core/main/tests/data/input/dflowfm_individual_files/with_optional_sections.mdu'
fm = hcdfm.FMModel(file_mdu)
Expected behavior
Reading file without issues
NOTE:
This in fact means support for URLs when loading a model. We need to think a bit further before implementing this:
what happens when calling fm.save() subsequently.
Upon loading, do we automatically set recurse=False, or not?
If we get a file from URL, that itself contains absolute file path references, what happens?
double check (in)compatibility with our current FilePathResolver
more...?
Version info (please complete the following information):
Version main branch
The text was updated successfully, but these errors were encountered:
NOTE: this issue requires futher refinement
Describe the request
When using a url as an input path, this error is raised
"OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\DATA\\dfm_tools\\tests\\examples\\https:\\raw.githubusercontent.com\\Deltares\\HYDROLIB-core\\main\\tests\\data\\input\\dflowfm_individual_files\\with_optional_sections.mdu'"
To Reproduce
Expected behavior
Reading file without issues
NOTE:
This in fact means support for URLs when loading a model. We need to think a bit further before implementing this:
fm.save()
subsequently.recurse=False
, or not?FilePathResolver
Version info (please complete the following information):
The text was updated successfully, but these errors were encountered: