You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
As part of #621, we can convert boundaries in an old ext file to boundaries in the new ext file, but this currently only concerns the ext files, not the underlying forcing files.
Under this issue we also want in the old input the old .tim / .cmp / .t3D files to be automatically converted into newly created .bc file.
Describe the solution you'd like
For every boundary quantity in the ExtOldModel.forcing list, check for the filename attribute whether it's a PolyFile and if so, then find whether there exists:
either a .tim file (with the same stem as the polyline filename)
or, alternatively, a .cmp file (same stem again)
or, as last check, a .t3D file (same stem again)
Additional context
The above conversion to some extent includes specific rules for boundary data. But, partly the .tim to .bc converter can also partially be based on generic .tim to .bc conversion: if you pass quantity name, function type, time interpolation settings and maybe some more settings to a utility function, then then creation of the ForcingModel object can furthermore be implemented generically.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
As part of #621, we can convert boundaries in an old ext file to boundaries in the new ext file, but this currently only concerns the ext files, not the underlying forcing files.
Under this issue we also want in the old input the old .tim / .cmp / .t3D files to be automatically converted into newly created .bc file.
Describe the solution you'd like
For every boundary quantity in the
ExtOldModel.forcing
list, check for thefilename
attribute whether it's aPolyFile
and if so, then find whether there exists:Additional context
The above conversion to some extent includes specific rules for boundary data. But, partly the .tim to .bc converter can also partially be based on generic .tim to .bc conversion: if you pass quantity name, function type, time interpolation settings and maybe some more settings to a utility function, then then creation of the
ForcingModel
object can furthermore be implemented generically.The text was updated successfully, but these errors were encountered: