Problem with gateLowerEdgeLevels of orifices (onderspuier) in D-HyDAMO

[rhutten]

Problem
The gateLowerEdgeLevel of an orifice is the position of the gate door's lower edge [m AD]. This is an absolute value in D-Flow FM.

However, the gateLowerEdgeLevels of orifices resulting from the D-HyDAMO converter is a relative value with respect to the crestLevel (laagstedoorstroomhoogte). This results from the 'hoogteopening' [m] being assigned as gateLowerEdgeLevel. More information about the D-HyDAMO onderspuier (orifice) can be found here.

The code below shows how the hoogteopening is assigned as gateLowerEdgeLevel:

1. weirs function in hydrolib/dhydamo/io/fmconverter.py:
   

Proposed solution

Adjust line 593 in weirs function in hydrolib/dhydamo/io/fmconverter.py to
gateloweredgelevel = weir_opening.laagstedoorstroomhoogte.values[0] + weir_mandev.hoogteopening.values[0]