-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add contacts testcase that fails in hydrolib-core on macos 14 arm64 #164
Labels
chore
Changes to the build process or auxiliary tools and libraries such as documentation generation
Comments
veenstrajelmer
added
the
chore
Changes to the build process or auxiliary tools and libraries such as documentation generation
label
Apr 29, 2024
This was referenced Apr 29, 2024
Running the above example on MacOS 14 arm64 produces the following output
|
veenstrajelmer
changed the title
add contacts testcase that fails in hydrolib-core on macos-14
add contacts testcase that fails in hydrolib-core on macos 14 arm64
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Changes to the build process or auxiliary tools and libraries such as documentation generation
What is the need for this task.
In Deltares/HYDROLIB-core#635 we found that HYDROLIB-core supports macos-12 and macos-13 on github. However, there is one failing testcase on macos-14. This is the only arm64 architecture, 12 and 13 are x86_64. This testcase uses meshkernel in the background. Also, the code was converted to meshkernelpy-only code and that also failed on the assertion. Therefore, it seems to point at a usecase that the meshkernelpy testbench does not cover yet.
What is the task?
Add this as a testcase to the meshkernelpy testbench. The meshkernel-only code is this:
This tests also only fails on macos-14 (on Github) on the line
assert network1_link1d2d.shape == (21, 2)
and with a comparable error message:assert (19, 2) == (21, 2)
(19 instead of 20 as in the original issue). This 19 should be 21 just like on other platforms/architecture.The code also produces this figure (on windows, so this is the reference/correct figure):
The text was updated successfully, but these errors were encountered: