Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default values for MeshRefinementParameters() #40

Closed
veenstrajelmer opened this issue Apr 5, 2023 · 1 comment
Closed

Set default values for MeshRefinementParameters() #40

veenstrajelmer opened this issue Apr 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@veenstrajelmer
Copy link
Collaborator

Describe the bug
There are no default values prescribed for the meshkernel.MeshRefinementParameters() parameters. I understand things like refinement_type have to be set by the user, but it would be convenient if there are defaults prescribed for some other parameters like refine_intersected and use_mass_center_when_refining.

To Reproduce

meshkernel.MeshRefinementParameters()

Raises: "TypeError: __init__() missing 6 required positional arguments: 'refine_intersected', 'use_mass_center_when_refining', 'min_face_size', 'refinement_type', 'connect_hanging_nodes', and 'account_for_samples_outside_face'"

Version info (please complete the following information):

  • OS: Windows
  • Version 2.0.2
@veenstrajelmer veenstrajelmer added the bug Something isn't working label Apr 5, 2023
@veenstrajelmer veenstrajelmer mentioned this issue Apr 5, 2023
Open
95 tasks
@ahmad-el-sayed
Copy link
Contributor

Done in #45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@veenstrajelmer @ahmad-el-sayed