Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create substance/concentration input tables #1123

Closed
evetion opened this issue Feb 15, 2024 · 2 comments
Closed

Create substance/concentration input tables #1123

evetion opened this issue Feb 15, 2024 · 2 comments
Assignees
Labels
waterquality Issues related to Delwaq coupling/functionality

Comments

@evetion
Copy link
Member

evetion commented Feb 15, 2024

For the boundaries, and set a similar table for the state of a basin (given it also has boundaries).

After a long discussion with Martijn, we ended up with a separate table type that has
id, time, substance, concentration columns. In #1111 I'm still using a concentration field on the existing static/time tables for the boundary nodes.

This data is all used for Delwaq input when coupling, but could also be used in the future for our own tracer/salt calculations.

@evetion evetion added enhancement waterquality Issues related to Delwaq coupling/functionality labels Feb 15, 2024
@github-project-automation github-project-automation bot moved this to To do in Ribasim Feb 15, 2024
@evetion evetion moved this from To do to What's next in Ribasim Feb 15, 2024
@Huite
Copy link
Contributor

Huite commented Feb 15, 2024

Conceptually, how would you make a distinction between drainage/infiltration concentrations versus precipitation? Or evaporation, which shouldn't subtract solutes (in general).

For what it's worth in terms of inspiration: MODFLOW 6 has a flow model and a transport model.
The flow model has a boundary, e.g. recharge: https://modflow6.readthedocs.io/en/latest/_mf6io/gwf-rch.html
In case of a linked transport model, the flow boundary has an auxiliary array defined with the concentration.
(A specific source can also be added separately, which does not add flow but does add solute.)

From the perspective of the user, solute concentrations are generally conceptually part of the boundary condition just as much as the flow (a hydrologist would prefer to think of the physical features first and foremost). In imod-python, we've chosen to add the concentration as an optional argument to the flow boundaries: https://deltares.github.io/imod-python/api/generated/mf6/imod.mf6.Recharge.html
This also makes it less likely that you forget to define concentrations for a boundary.

@evetion evetion added the needs-refinement Issues that are too large and need refinement label Feb 15, 2024
@SnippenE SnippenE removed the needs-refinement Issues that are too large and need refinement label Feb 22, 2024
@evetion evetion moved this from What's next to Sprint backlog in Ribasim Apr 4, 2024
@elinenauta elinenauta moved this from Sprint backlog to 🏗 In progress in Ribasim Apr 4, 2024
@evetion evetion moved this from 🏗 In progress to ✅ Done in Ribasim May 7, 2024
@evetion
Copy link
Member Author

evetion commented May 7, 2024

Done in #1267

@evetion evetion closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waterquality Issues related to Delwaq coupling/functionality
Projects
Archived in project
Development

No branches or pull requests

4 participants