Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to new RWS WaterWebservices #113

Open
5 of 18 tasks
veenstrajelmer opened this issue Oct 7, 2024 · 0 comments · May be fixed by #124
Open
5 of 18 tasks

update to new RWS WaterWebservices #113

veenstrajelmer opened this issue Oct 7, 2024 · 0 comments · May be fixed by #124

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 7, 2024

  • ddlpy version: 0.5.0
  • Python version: 3.11
  • Operating System: Windows 10

Description

The RWS WaterWebservices will be updated in 2025: https://rijkswaterstaatdata.nl/projecten/beta-waterwebservices/
ddlpy has to be updated to work with the new urls and filters:

  • new url: https://waterwebservices.beta.rijkswaterstaat.nl/test/METADATASERVICES/OphalenCatalogus
  • HTTPError 204 in case of no data (instead of "Geen gegevens gevonden!")
  • New ProcesType for distinction between verwacht/meting/astro
  • also update to ProcesType in cli testcase, example script and notebook and maybe more
  • how to distinguish between extremes and timeseries? >> seems to be still via Groepering
  • Groepering is now sometimes empty string, this cannot be subsetted with cli since empty strings cannot be passed as options
  • remove list-to-str/int conversion (Kwaliteitswaardecode is now a string instead of a list), tests are in place to make sure datatypes stay constant
  • check if waterinfo csv format will also change with new waterwebservices. If so, make more generic so it does not matter.
  • add deprecationwarning to ddlpy.read_waterinfo() function, "let us know if you use this"
  • resolve all added TODO's in branch
  • check if all "DDL/waterwebservices api improvements" tasks in DDL improvements (data and waterwebservices) Deltares-research/kenmerkendewaarden#4 are ticked by new WaterWebservices, consider moving them to this issue.
  • consider dropping Hoedanigheid from catalog #89 >> if no stations with LAT and MSL referenced measurements
  • update all docs again
  • update changelog

After release update:

  • dfm_tools (incl release and minimal ddlpy version)
  • hatyan (incl release and minimal ddlpy version)
  • kenmerkendewaarden (incl release and minimal ddlpy version), also new data retrieve and new data delivery (with new station codes)
  • getijverandering scripts?
@veenstrajelmer veenstrajelmer changed the title update to new waterwebservices update to new RWS WaterWebservices Oct 8, 2024
@veenstrajelmer veenstrajelmer linked a pull request Oct 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant