Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide private functions #632

Closed
4 tasks done
veenstrajelmer opened this issue Nov 2, 2023 · 0 comments · Fixed by #634
Closed
4 tasks done

Hide private functions #632

veenstrajelmer opened this issue Nov 2, 2023 · 0 comments · Fixed by #634

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Nov 2, 2023 •
edited
Loading

E.g. in download.py:

__all__ = [
    "download_ERA5",
    "download_CMEMS",
]

TODO:

  • add __all__ to all scripts
  • remove _ from current private functions
  • run entire testbank and example notebooks after making functions private
  • check if api reference decreased in size (first function was cds_client_withargs) >> no, still a mess
@veenstrajelmer veenstrajelmer mentioned this issue Nov 2, 2023
Closed
13 tasks
@veenstrajelmer veenstrajelmer linked a pull request Nov 3, 2023 that will close this issue
defined __all__ in each script #634
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

defined __all__ in each script Deltares/dfm_tools
1 participant
@veenstrajelmer