Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize finding of sigma layer variables #764

Closed
veenstrajelmer opened this issue Feb 2, 2024 · 0 comments · Fixed by #765
Closed

Generalize finding of sigma layer variables #764

veenstrajelmer opened this issue Feb 2, 2024 · 0 comments · Fixed by #765

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Feb 2, 2024

Generalizing update needed in reconstruct_zw_zcc() for #648 and probably others:

# elif f'{gridname}_layer_sigma' in uds.variables: #TODO: var with standard_name='ocean_sigma_coordinate' available?
elif len(uds.filter_by_attrs(standard_name='ocean_sigma_coordinate')) != 0:

This keeps the unit/systemtests green, so seems like no-regret although good to test with other old sigma models (not included in postprocess_mapnc_ugrid.py acceptance test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant