Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ddl ssh subset and retrieval to new ddlpy release #813

Closed
6 tasks done
Tracked by #805
veenstrajelmer opened this issue Apr 8, 2024 · 0 comments · Fixed by #815
Closed
6 tasks done
Tracked by #805

Update ddl ssh subset and retrieval to new ddlpy release #813

veenstrajelmer opened this issue Apr 8, 2024 · 0 comments · Fixed by #815

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Apr 8, 2024 •
edited
Loading

Todo:

  • drop meta_dict argument from rwsddl_ssh_retrieve_data(), this argument is not used anymore
  • simplify code by using ddlpy.dataframe_to_xarray()
  • Create ddlpy 0.4.0 release ddlpy#90
  • update minimal ddlpy version in pyproject.toml
  • open PR
  • update whats-new.md

how to use ddlpy.dataframe_to_xarray:

drop_if_constant = ["WaarnemingMetadata.OpdrachtgevendeInstantieLijst",
                    "WaarnemingMetadata.BemonsteringshoogteLijst",
                    "WaarnemingMetadata.ReferentievlakLijst",
                    "AquoMetadata_MessageID", 
                    "BioTaxonType",
                    "BemonsteringsSoort.Code", 
                    "Compartiment.Code", "Eenheid.Code", "Grootheid.Code", "Hoedanigheid.Code",
                    ]
ds = ddlpy.dataframe_to_xarray(measurements, drop_if_constant)
@veenstrajelmer veenstrajelmer mentioned this issue Apr 8, 2024
Closed
11 tasks
@veenstrajelmer veenstrajelmer changed the title drop meta_dict argument from rwsddl_ssh_retrieve_data() Improve ddl ssh subset and retrieval Apr 8, 2024
@veenstrajelmer veenstrajelmer changed the title Improve ddl ssh subset and retrieval Update ddl ssh subset and retrieval to new ddlpy release Apr 8, 2024
@veenstrajelmer veenstrajelmer linked a pull request Apr 8, 2024 that will close this issue
813 update ddl ssh subset and retrieval to new ddlpy release #815
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

813 update ddl ssh subset and retrieval to new ddlpy release Deltares/dfm_tools
1 participant
@veenstrajelmer