Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_prevent_dtype_int fails in mindeps github test #892

Closed
veenstrajelmer opened this issue Jul 9, 2024 · 1 comment
Closed

test_prevent_dtype_int fails in mindeps github test #892

veenstrajelmer opened this issue Jul 9, 2024 · 1 comment

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 9, 2024

tests/test_xarray_helpers.py::test_prevent_dtype_int fails after updating hydrolib-core minimal version in branch of #890. But since that is the only difference (also after comparing environment dependency versions), this cannot be the issue. Check again with testcase that runs on main branch.

It succeeded in main, but failed again after another PR. See if this happens more often, but not always so it is a bit arbitrary.

@veenstrajelmer veenstrajelmer closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
@veenstrajelmer veenstrajelmer reopened this Jul 9, 2024
@veenstrajelmer veenstrajelmer changed the title tests/test_xarray_helpers.py::test_prevent_dtype_int fails in mindeps github test test_prevent_dtype_int fails in mindeps github test Jul 10, 2024
@veenstrajelmer
Copy link
Collaborator Author

prevent_dtype_int and its test were removed in #943 because they became redundant. Therefore, this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant