Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of entrypoints should be deprecated #454

Closed
2 tasks done
savente93 opened this issue Jul 21, 2023 · 2 comments · Fixed by #676
Closed
2 tasks done

use of entrypoints should be deprecated #454

savente93 opened this issue Jul 21, 2023 · 2 comments · Fixed by #676
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@savente93
Copy link
Contributor

HydroMT version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of HydroMT.

Reproducible Example

https://pypi.org/project/entrypoints/

Current behaviour

Currently HydroMT uses the entrypoints packages to advertise entry points for the plugins to use. However the PyPi page of entrypoints lists the current paragraph:

This package is in maintenance-only mode. New code should use the importlib.metadata module in the Python standard library to find and load entry points.

Desired behaviour

Whenever possible we should prefer dependencies that are actively maintained, therefore we should investigate the possibility of moving away from entrypoints and use the new standard library functionality for this if possible

Additional context

No response

@savente93 savente93 added Bug Something isn't working Needs refinement issue still needs refinement labels Jul 21, 2023
@DirkEilander
Copy link
Contributor

Thanks for spotting this! The alternative standard library seems like the go-to alternative. @savente93 could you research what is required to replace entrypoints by the standard library? We use it to define an entrypoint in the pyproject.toml files of plugins which points to an child of the Model class in that plugin. These entrypoints are found and loaded in hydromt/models/model_plugins.py

@savente93
Copy link
Contributor Author

sure thing, will do!

@savente93 savente93 added this to the Q4 milestone Jul 31, 2023
@savente93 savente93 self-assigned this Aug 1, 2023
@savente93 savente93 added Maintenance and removed Needs refinement issue still needs refinement labels Aug 1, 2023
@DirkEilander DirkEilander modified the milestones: Q4, v1.0 Sep 21, 2023
@alimeshgi alimeshgi assigned Jaapel and unassigned savente93 Dec 21, 2023
@savente93 savente93 modified the milestones: v1.0, v1.0 alpha May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants