Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meshkernel API calls to version 3.0.0 #105

Closed
2 of 4 tasks
veenstrajelmer opened this issue Oct 23, 2023 · 0 comments · Fixed by #109
Closed
2 of 4 tasks

Update meshkernel API calls to version 3.0.0 #105

veenstrajelmer opened this issue Oct 23, 2023 · 0 comments · Fixed by #109
Labels
enhancement New feature or request

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 23, 2023

Kind of request

Changing existing functionality

Enhancement Description

With the upcoming release of meshkernel 3.0.0, there are some API calls in meshgeneration that need to be updated. Since we depend on hydrolib-core, the 569-bumping-meshkernel-version-to-latest-v300 branch can be used to test with the version of hydrolib-core that has update API calls. This branch is work in progress though. An overview of API changes is available in this issue and its comments: Deltares/dfm_tools#563

Additionally:

  • update minimal meshkernel version in pyproject.toml >=3.0.0
  • update env for github testing
  • revert hydrolib-core and xugrid git link in pyproject.toml and env files
  • this might be a good chance to move hydrolib-core mesh generation to meshkernel calls from hydromt_delft3dfm directly

Use case

No response

Additional Context

No response

@veenstrajelmer veenstrajelmer added the enhancement New feature or request label Oct 23, 2023
@veenstrajelmer veenstrajelmer linked a pull request Oct 27, 2023 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant