Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I want the network to be a data class #107

Closed
frederique-hub opened this issue Jul 6, 2023 · 0 comments · Fixed by #161
Closed

As a developer, I want the network to be a data class #107

frederique-hub opened this issue Jul 6, 2023 · 0 comments · Fixed by #161
Assignees
Labels
enhancement New feature or request

Comments

@frederique-hub
Copy link
Contributor

frederique-hub commented Jul 6, 2023

The current NetworkIniConfigData should become a dataclass:

  • This implies removing the NetworkIniConfigDataReader or convert it in a data builder.
  • Network class might be renamed to NetworkController (or else), whose config argument becomes the NetworkIniConfigData.
  • The current create should be broke down into different steps and generalized so we have "workflows".
    • Create specific workflows for each type of 'network' origin that there is. Delegating creation responsibility in said classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants