Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptation: extend returned column results #665

Closed
MatthiasHauthDeltares opened this issue Dec 17, 2024 · 0 comments · Fixed by #668
Closed

Adaptation: extend returned column results #665

MatthiasHauthDeltares opened this issue Dec 17, 2024 · 0 comments · Fixed by #668
Assignees
Labels
enhancement New feature or request triage required Issues without priority assessment or milestone.

Comments

@MatthiasHauthDeltares
Copy link
Contributor

Kind of request

None

Enhancement Description

This is the columns currently returned in the adaptation result gdf:
Image

  • AO0_impact_damages should be only AO_damages. Impact is the sum of damage and losses, so it does not make sense to call damages "impact_damage"
  • Benefit is impact_AO0 - impact_AO1. not the other way around
  • rename current impact by "net_impact" and add "event_impact" which is the impact without multiplying with net_present_value_factor

Use case

No response

Additional Context

No response

@MatthiasHauthDeltares MatthiasHauthDeltares added enhancement New feature or request triage required Issues without priority assessment or milestone. labels Dec 17, 2024
@ArdtK ArdtK self-assigned this Dec 20, 2024
@ArdtK ArdtK added this to the Sprint 2024 Q4.4 milestone Dec 20, 2024
@ArdtK ArdtK mentioned this issue Dec 20, 2024
7 tasks
@ArdtK ArdtK linked a pull request Jan 2, 2025 that will close this issue
7 tasks
@ArdtK ArdtK closed this as completed in #668 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage required Issues without priority assessment or milestone.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants