New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRs should skip to deploy to Github Pages #306

Open

JoerivanEngelen opened this issue Nov 5, 2024 · 0 comments

Contributor

JoerivanEngelen commented Nov 5, 2024 •

edited

Loading

Currently, our CI always tries to deploy to Github Pages, also in PRs. What happens depends on the developer creating this PR.

For people member with the appropriate rights, the job succeeds. This is unwarrented, as documentation is pushed which is not in the main branch.
Jobs fail for accounts outside the Deltares group, e.g. Make pixi update PR nicer #305 , this discourages contributing to the code base.

JoerivanEngelen mentioned this issue

Make pixi update PR nicer #305

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment