Skip to content
This repository has been archived by the owner on Aug 5, 2023. It is now read-only.

Refactor main navigation #146

Open
danhannigan opened this issue Sep 21, 2022 · 7 comments
Open

Refactor main navigation #146

danhannigan opened this issue Sep 21, 2022 · 7 comments
Assignees
Labels
design enhancement New feature or request refactor

Comments

@danhannigan
Copy link
Member

I had pulled the main navigation from some online source when I was building the site initially, and I have to admit it's not exactly as clean or as friendly as I would like in terms of updating and maintaining - I'd like to refactor it, and I'm open to any thoughts or ideas there. I like the general style of it.

@rhyn0bytes
Copy link

@danhannigan is this project still participating in hacktoberfest? Either way, I would like to take a crack at refactoring the navigation.

@danhannigan
Copy link
Member Author

Hey @rhyn0bytes it is! I just dropped the tags to prevent some spam I was seeing. I'll still flag it as hacktoberfest-approved once we get it all worked out!

@rhyn0bytes
Copy link

Going to start a nav-refactor branch tomorrow and see what I can get through. I am going to ignore the hydration error (I cannot tell if it is coming from the window.gtag trying to load out of sync on my dev env

@danhannigan
Copy link
Member Author

Right on, thanks @rhyn0bytes! Feel free to ping me with questions at any time - let's keep the styling & functionality as close to the original as possible.

And yeah, you'll likely encounter goofy bugs (if you see anything particularly troubling, go ahead and pop open an issue ticket), the website update has been more of a side-side project of mine and hasn't gotten the due diligence it deserves!

@rhyn0bytes rhyn0bytes self-assigned this Oct 4, 2022
@danhannigan
Copy link
Member Author

Hey @rhyn0bytes was this something you were still tinkering on? If not that's totally okay, I'll likely just hop in and work on the refactor myself!

@rhyn0bytes
Copy link

rhyn0bytes commented Nov 10, 2022

Hey @rhyn0bytes was this something you were still tinkering on? If not that's totally okay, I'll likely just hop in and work on the refactor myself!

Hi @danhannigan, I'm so sorry. I let the whole month just run away from me. I started a refactor a few weeks ago. Let me clean up and get you a PR to look at. Would this upcoming weekend be alright?

@danhannigan
Copy link
Member Author

@rhyn0bytes oh no need to apologize! There's no rush at all, I just wanted to check in on it and make sure I wasn't going to start on work if you already had something in a good spot, feel free to sling it on up whenever you'd like!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design enhancement New feature or request refactor
Projects
None yet
Development

No branches or pull requests

2 participants