Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation or Inclusion of other algorithms #174

Closed
BradKML opened this issue Jun 18, 2021 · 4 comments
Closed

Documentation or Inclusion of other algorithms #174

BradKML opened this issue Jun 18, 2021 · 4 comments
Assignees
Labels
good first issue items that are good as starting points for new contributors help wanted question

Comments

@BradKML
Copy link

BradKML commented Jun 18, 2021

The models and algorithms in https://github.com/boudinfl/pke#implemented-models are similar to Textrank but not sped up by SpaCy, so it might be a good idea to include them in PyTextRank

PS: There are also other non TextRank-esque algorithms to consider when making this assessment:

@louisguitton
Copy link
Contributor

thanks for bringing our attention to pke !

this issue is similar to #78 for which we have made already great progress with 2 contributions:

  • adding PositionRank and BiasedRank
  • adding BaseTextRank and BaseTextRankFactory to enable integration of more flavours

Regarding the graph based models of pke, I can see this:

  • their TextRank can be achieved with our BaseTextRank(edge_weight=0)
  • their SingleRank can be achieved with our BaseTextRank() or BaseTextRank(edge_weight=1.0)
  • their PositionRank can be achieved with our PositionRank

the following ones are missing:

I was not aware of these 3 papers and approaches so thank you.
Do you have experience with them in practice and are they good?
Would you be open to contribute them?

@BradKML
Copy link
Author

BradKML commented Jul 16, 2021

To reiterate the current algorithms that are not included:

Looking at

@ceteri
Copy link
Collaborator

ceteri commented Mar 7, 2022

Also check the algorithms listed in pke https://github.com/boudinfl/pke which has an excellent range of implementations. FWIW, that library is GPL and not implemented as a spaCy pipeline, so there's some room for algorithm implementations both there (for research) and here (for production deployments).

@DerwenAI DerwenAI locked and limited conversation to collaborators Aug 22, 2023
@ceteri ceteri converted this issue into discussion #251 Aug 22, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
good first issue items that are good as starting points for new contributors help wanted question
Projects
None yet
Development

No branches or pull requests

3 participants