Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR body uses hardcoded branch name #110

Open
srid opened this issue May 26, 2024 · 1 comment
Open

PR body uses hardcoded branch name #110

srid opened this issue May 26, 2024 · 1 comment

Comments

@srid
Copy link

srid commented May 26, 2024

The branch name update_flake_lock_action is hardcoded here:

git branch -D update_flake_lock_action
git fetch origin
git checkout update_flake_lock_action
git commit --amend --no-edit
git push origin update_flake_lock_action --force

But this becomes incorrect, when the user overrides it in the workflow YAML as I do here. This results in creating PRs with wrong instructions:

srid/haskell-flake#321

The PR body refers to branch update_flake_lock_action contradicting the actual branch update_flake_lock_example.

@srid
Copy link
Author

srid commented Aug 4, 2024

Aside: I wrote this little Nu script to automate the steps, taking the PR URL directly.

srid/nixos-config@db392e4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant