Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's no way to know whether an update happened #70

Open
lovesegfault opened this issue Mar 14, 2023 · 1 comment
Open

There's no way to know whether an update happened #70

lovesegfault opened this issue Mar 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lovesegfault
Copy link

Currently, there is no way of telling whether an update happened, which means any following actions which rely on the pull-request-number output just get a PR number of 0 and fail.

      - uses: DeterminateSystems/update-flake-lock@v17
        id: update-flake
        with:
          branch: update-${{ matrix.flake }}
          commit-msg: "chore(flake/${{ matrix.flake }}): update"
          git-author-email: hatesegfault@protonmail.ch
          git-author-name: hatesegfault
          inputs: ${{ matrix.flake }}
          pr-title: "chore(flake/${{ matrix.flake }}): update"
          token: ${{ secrets.PAT }}
      - uses: peter-evans/enable-pull-request-automerge@v2
        with:
          token: ${{ secrets.PAT }}
          pull-request-number: ${{ steps.update-flake.outputs.pull-request-number }}
          merge-method: rebase

Something like the above will fail whenever there's no update for matrix.flake. There should be a way to say if: ${{ steps.update-flake.outputs.updated == 'true' }} for follow-up steps.

@cole-h cole-h added the enhancement New feature or request label Mar 27, 2023
@cole-h
Copy link
Member

cole-h commented Mar 27, 2023

That would make sense. I can't guarantee I'll get to it any time soon (as you can see by the already-delayed response time.... sorry about that), but a PR would definitely be welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants