Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with page src/pages/start/1.install.mdx #160

Open
stuartlangridge opened this issue Jan 23, 2023 · 0 comments
Open

Issue with page src/pages/start/1.install.mdx #160

stuartlangridge opened this issue Jan 23, 2023 · 0 comments

Comments

@stuartlangridge
Copy link

stuartlangridge commented Jan 23, 2023

https://zero-to-nix.com/start/install has a disclosure element, text "Why aren't we using the official Nix installation script here?". This seems to be some sort of JavaScript-driven expander, and doesn't work if the page's JS doesn't load; it can't be keyboard focused or opened, either. It doesn't need to be; this is exactly what the HTML details element is for, and that works everywhere, and has built-in accessibility which this does not. It would be a lot better to use HTML and not require scripting for this, so you don't need to reimplement all the features that an actual HTML element provides for you, perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant