You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
I am noticing several UI inconsistencies as follows.
The sidebar spacing is a bit off. I've corrected it and this is the result. I am showing it alongside Finder to show how it should look.
We may even consider replacing categories with collapsable list section headings instead of using an outline view (similar to the FInder sidebar - "Favorites", "iCloud", "Locations", "Tags"). This would save space and flatten up our navigation.
Changing ToolmenuCell to this should fix this. Then resize all the icon image files from 16x16 to 20x20 (or just download the resized files here).
import CoreUtil
finalclassToolmenuCell:NSLoadView{staticletheight:CGFloat=28vartitle:String{get{ titleLabel.stringValue }set{ titleLabel.stringValue = newValue }}varicon:NSImage?{get{ iconView.image }set{ iconView.image = newValue }}privatelettitleLabel=NSTextField(labelWithString:"Title")privateleticonView=NSImageView()overridefunc onAwake(){self.snp.makeConstraints{ make in
make.height.equalTo(Self.height)}self.addSubview(iconView)self.iconView.snp.makeConstraints{ make in
make.size.equalTo(20)
make.left.equalTo(0)
make.centerY.equalToSuperview()}self.addSubview(titleLabel)self.titleLabel.lineBreakMode =.byTruncatingTail
self.titleLabel.font =.systemFont(ofSize:R.Size.controlTitleFontSize)self.titleLabel.snp.makeConstraints{ make in
make.left.equalTo(self.iconView.snp.right).offset(4)
make.right.equalToSuperview().inset(4)
make.centerY.equalToSuperview()}}}
The search bar is too small. See the search bar in Music, Finder, App Store or any other app and see that it should be a bit taller.
The search bar should also scroll with the overflow and when scrolled, a subtle line should appear dividing the window controls from the sidebar content.
(You get most of this for free by the way with SwiftUI, so we may consider using it instead.)
I am also noticing that there is unnecessary overflow on some of the screens where the text inputs are sized to fit the window height.
The text was updated successfully, but these errors were encountered:
@austincondiff Thank you for your issue!!! I also think it is very important to be like native app. Thank you for all the materials. Thanks to your help, I was able to do the modification easily.
This is what it looks like now. It now looks more like Apple's music app.
@ObuchiYuki Very nice work, looks perfect. I am new to Swift (coming from React) so I am not as familiar with Cocoa (mainly just SwiftUI) otherwise I would have just submitted a PR. Glad to see it didn't take you too long, I spent a whole weekend trying to figure out how to replace the NSOutlineView with subheadings and navigation items. 😅
I am noticing several UI inconsistencies as follows.
The sidebar spacing is a bit off. I've corrected it and this is the result. I am showing it alongside Finder to show how it should look.
We may even consider replacing categories with collapsable list section headings instead of using an outline view (similar to the FInder sidebar - "Favorites", "iCloud", "Locations", "Tags"). This would save space and flatten up our navigation.
Changing
ToolmenuCell
to this should fix this. Then resize all the icon image files from 16x16 to 20x20 (or just download the resized files here).The search bar is too small. See the search bar in Music, Finder, App Store or any other app and see that it should be a bit taller.
The search bar should also scroll with the overflow and when scrolled, a subtle line should appear dividing the window controls from the sidebar content.
(You get most of this for free by the way with SwiftUI, so we may consider using it instead.)
I am also noticing that there is unnecessary overflow on some of the screens where the text inputs are sized to fit the window height.
The text was updated successfully, but these errors were encountered: