Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preconstruct dev builds are being published to npm #107

Closed
Dhaiwat10 opened this issue Dec 13, 2021 · 2 comments · Fixed by #108 or #111
Closed

preconstruct dev builds are being published to npm #107

Dhaiwat10 opened this issue Dec 13, 2021 · 2 comments · Fixed by #108 or #111
Assignees
Labels

Comments

@Dhaiwat10
Copy link
Member

Dhaiwat10 commented Dec 13, 2021

https://unpkg.com/@web3-ui/components@0.1.1/dist/
https://codesandbox.io/s/confident-davinci-uce8t?file=/src/App.js

The current publish script does not run yarn build before publishing the packages to npm which is resulting in the dev builds being pushed to npm.

@Dhaiwat10 Dhaiwat10 self-assigned this Dec 13, 2021
@Dhaiwat10 Dhaiwat10 mentioned this issue Dec 13, 2021
@Dhaiwat10
Copy link
Member Author

The builds are still broken. :(

@Dhaiwat10
Copy link
Member Author

Ok, so the problem is https://www.runpkg.com/?@rsksmart/rlogin-ledger-provider@1.0.2-beta.2. This is being used in the hooks package. This leads to errors such as these:
image

The next plan of action is to remove the Coinbase and Ledger wallet providers from the hooks package. This will 1. fix the hooks package (and in turn, the core package) breaking on run-time and 2. decrease the bundle size a lot since that rlogin-ledger-provider costs 2MB lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant