Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Storybook deployments (and preview deployments) #49

Closed
Dhaiwat10 opened this issue Dec 2, 2021 · 7 comments
Closed

Setup Storybook deployments (and preview deployments) #49

Dhaiwat10 opened this issue Dec 2, 2021 · 7 comments
Assignees
Labels

Comments

@Dhaiwat10
Copy link
Member

It would be great to have a deployed version of our Storybook(s) that anyone can access without having to pull down a branch and starting the Storybook server locally. This will be helpful for reviewing PRs too.

Helpful links:

@etr2460
Copy link
Contributor

etr2460 commented Dec 2, 2021

I was thinking about setting this up with vercel originally, but chromatic would probably work too. love the idea!

@with-heart
Copy link
Member

@alanpcurrie has done a lot of work in a similar direction with https://github.com/Developer-DAO/developerdao.com/pull/178. Might be interesting to take a look at his work or have him assist with this as well!

@christiananese
Copy link
Contributor

Hey @etr2460 are you already working on this one? If not @Dhaiwat10 can I be assigned?

@Dhaiwat10
Copy link
Member Author

Dhaiwat10 commented Dec 2, 2021

Assigning this to you @christiananese, grazie

@etr2460
Copy link
Contributor

etr2460 commented Dec 3, 2021

yup, i haven't dug into it, it's all yours @christiananese !

@etr2460
Copy link
Contributor

etr2460 commented Dec 3, 2021

fyi #60 alters the storybook setup somewhat (puts both hooks and components into the same storybook) so you might need to rebase on it before PRing any work here. let me know if you need help!

@christiananese
Copy link
Contributor

Closing this PR #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants