Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the interface of useWallet hook #67

Closed
emanueltimlopez opened this issue Dec 3, 2021 · 6 comments
Closed

Improve the interface of useWallet hook #67

emanueltimlopez opened this issue Dec 3, 2021 · 6 comments
Assignees

Comments

@emanueltimlopez
Copy link

emanueltimlopez commented Dec 3, 2021

Its hard to know what hook exposes.

I think we can declare an interface in the provider and only provide the connection properties when connection is success.

@emanueltimlopez emanueltimlopez changed the title Improve the interface of hook useWallet Improve the interface of useWallet hook Dec 3, 2021
@Dhaiwat10
Copy link
Member

@emanueltimlopez I think we still want to keep the current connection API. The connection object being the single source of truth & reactive store is something I really like. Let me know if you have other ideas and why, though! I'm open to new ideas.

The issue is with all those undefined and null cases. You'll often come across context?.something in the code which is not ideal. We want to clean that up.

@emanueltimlopez
Copy link
Author

i undertand, i think its a lot better now
Captura de Pantalla 2021-12-04 a la(s) 11 16 04

BTW i dont have permission to push my branch @Dhaiwat10

@etr2460
Copy link
Contributor

etr2460 commented Dec 4, 2021

@emanueltimlopez if you don't have write permission to the repo, you can fork it, push a branch to your fork, and then open the PR here

@Dhaiwat10
Copy link
Member

@emanueltimlopez I have made some changes to the useWallet hook via #74. Please have a look at that PR and keep those in mind!

@Dhaiwat10
Copy link
Member

@allcontributors add @emanueltimlopez for code! <3

@allcontributors
Copy link
Contributor

@Dhaiwat10

I've put up a pull request to add @emanueltimlopez! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants