Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Major refactor + Typescript #1652

Open
notVitaliy opened this issue Jul 6, 2018 · 2 comments
Open

Major refactor + Typescript #1652

notVitaliy opened this issue Jul 6, 2018 · 2 comments

Comments

@notVitaliy
Copy link

notVitaliy commented Jul 6, 2018

I don't know if you guys are interested or not but I created a private clone of this repo a few days ago and started a huge refactor as well as converted everything to typescript.

I'm able to get it to run on my machine already as-is but there is still a ton more work left to do.

My main goals:

  • Get rid of all the side effects
    • The s object gets passed around and mutated
    • This makes it difficult to track down bugs and trace exactly what's happening
  • Implement ES6/Typescript classes
  • Use functional programming principles where possible
  • Reduce code repetition (DRY principles)
  • New structure with a heavy focus on separation of concerns

image

Stretch Goals:

  • Create a behavior tree to process signals
  • Allow multiple currency/asset pairs to run simultaneously
  • Cross-exchange arbitrage
  • Implement Node 10.5 treading to offload TI/TA processing from the main thread
@notVitaliy
Copy link
Author

Here's a quick sample of the main entry refactor: index.ts, boot.ts and config.ts

image

@notVitaliy
Copy link
Author

Started work on a re-write of the engine last night. I've ripped it out into Core and have the writeReport abstracted into it's own class Report.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants