Sims not buying/selling at correct pct on Binance with BTC currency.

[rountrey]

System information

• Have I written custom code (as opposed to using zenbot vanilla): Vanilla besides config files
• OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04
• Zenbot version (commit ref, or version): 4.1.0
• Zenbot branch: stable
• NodeJS version: 8.11.3
• Python version (when using a python script): 2.7.14
• Exact command to reproduce (include everything): for sims only, ANY strategy, any options, as long as the selector is binance.***-BTC
• Did I make any changes to conf-sample.js?: No

Describe the problem

This is a serious bug in running sims on Binance with BTC, at least to me. It has to do with the buy_pct and sell_pct. I have tried to run sims on any stock strategy with binance.TUSD-BTC, binance.STORM-BTC, binance.XRP-BTC, binance.XMR-BTC, binance.ETH-BTC, and about 10 more. The buy and sell percentages are not working. For example, if set the asset/currency to 100ETH and 100BTC, and the buy/sell_pct at 90, when it buys it should leave me with 10BTC (or close to it with the fees). But it ends up being, 99.999990 or something like that.

This happens regardless of setting the options in command line or in a config file. But it only happens on Binance and only if the currency is set with BTC, It works fine BNB, ETH, and USDT. And regardless of maker or taker. This is only on sims, it works fine on paper, and have not tested on live mode.

I have checked and rechecked to see if I put a period before my buy/sell_pct options, I have looked at everything that I changed over and over and found nothing that could cause this. I have not looked at anything in lib/.

[rountrey]

Apparently it does it with ETH, too.

./zenbot.sh sim --days 60 binance.XRP-ETH --strategy dema --buy_pct=90 --sell_pct=90 --period=5m --max_sell_loss_pct 10 --max_buy_loss_pct 15 --ema_short_period=5 --ema_long_period=10 --up_trend_threshold=0 --down_trend_threshold=0 --overbought_rsi_periods=9 --overbought_rsi=99 --noise_level_pct=0