You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
This request is a really too small for a PR.
For proper (early) initiatiation of the websocket functions we need one single parameter passed as an option to the getProducts function on line 22 of the lib/engine.js file, The parameter is s.product_id
In the future it may prove useful to change the name to exchangeInit(params) and make it a callback for exchange spesific information such as API capabilities. Just a thought.
This change is desparately needed for further work on websockets implementation.
(Even the whole s object could have been passed. In that case it probably wold have been the smallest change ever. LOL)
The text was updated successfully, but these errors were encountered:
@EigilB I don't understand why this is "too small for a PR", nothing is too small for a PR. Could you send in a PR showcasing what you exactly need? I think that code is easier to reason about than words.
This request is a really too small for a PR.
For proper (early) initiatiation of the websocket functions we need one single parameter passed as an option to the
getProducts function on line 22 of the lib/engine.js file, The parameter is s.product_id
In the future it may prove useful to change the name to exchangeInit(params) and make it a callback for exchange spesific information such as API capabilities. Just a thought.
This change is desparately needed for further work on websockets implementation.
(Even the whole s object could have been passed. In that case it probably wold have been the smallest change ever. LOL)
The text was updated successfully, but these errors were encountered: