Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The features chart should have a maximum of 100% #470

Open
brunnerh opened this issue Dec 16, 2024 · 4 comments
Open

The features chart should have a maximum of 100% #470

brunnerh opened this issue Dec 16, 2024 · 4 comments

Comments

@brunnerh
Copy link

Capping it at the most selected feature in the group is silly, it makes the bars useless.
image

What is the point of seeing that findLast is being 80% as used as toSorted?

@SachaG
Copy link
Member

SachaG commented Dec 17, 2024

That's a fair point, but the downside of using 100% everywhere is that it makes other charts less readable when each item receives a small amount of votes.

Screenshot 2024-12-17 at 10 52 48

So I'm not quite sure which is better…

@pwim
Copy link
Collaborator

pwim commented Dec 17, 2024

This article suggests not extending it to 100%, but rather ending it close to where the data ends (the current behaviour). Some other resources confirmed that is the recommended strategy, but I didn't look deeply into it.

@SachaG
Copy link
Member

SachaG commented Dec 17, 2024

OK, let's keep it like this for now then.

@brunnerh
Copy link
Author

brunnerh commented Dec 17, 2024

That's a fair point, but the downside of using 100% everywhere [...]

I am not suggesting that, I am only referring to features where the main thing of interest is how many people know or have used it in total and the relation to the other bars does not really matter. In the podcast example, the relative values are more interesting since the bars are more related and comparing them against each other makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants