Skip to content

Commit 6969368

Browse files
committed
feat: support username + password in private key secret entry
1 parent 06962fd commit 6969368

File tree

3 files changed

+13
-10
lines changed

3 files changed

+13
-10
lines changed

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
0.12.2
1+
0.12.3

entry_credential.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,11 @@ type EntryCredentialDefaultData struct {
4848
}
4949

5050
type EntryCredentialPrivateKeyData struct {
51-
PrivateKey string `json:"privateKeyData,omitempty"`
52-
PublicKey string `json:"publicKeyData,omitempty"`
53-
OverridePassword string `json:"privateKeyOverridePassword,omitempty"`
54-
Passphrase string `json:"privateKeyPassPhrase,omitempty"`
51+
Username string `json:"privateKeyOverrideUsername,omitempty"`
52+
Password string `json:"privateKeyOverridePassword,omitempty"`
53+
PrivateKey string `json:"privateKeyData,omitempty"`
54+
PublicKey string `json:"publicKeyData,omitempty"`
55+
Passphrase string `json:"privateKeyPassPhrase,omitempty"`
5556
}
5657

5758
func (e *Entry) GetCredentialAccessCodeData() (*EntryCredentialAccessCodeData, bool) {

entry_credential_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,11 @@ func test_NewUserEntry(t *testing.T) {
201201
Tags: []string{"testtag"},
202202

203203
Data: EntryCredentialPrivateKeyData{
204-
PrivateKey: "-----BEGIN PRIVATE KEY-----\abcdefghijklmnopqrstuvwxyz1234567890...\n-----END PRIVATE",
205-
PublicKey: "-----BEGIN PUBLIC KEY-----\abcdefghijklmnopqrstuvwxyz...\n-----END PUBLIC KEY-----",
206-
OverridePassword: "override-password",
207-
Passphrase: "passphrase",
204+
Username: "testuser",
205+
Password: "password",
206+
PrivateKey: "-----BEGIN PRIVATE KEY-----\abcdefghijklmnopqrstuvwxyz1234567890...\n-----END PRIVATE",
207+
PublicKey: "-----BEGIN PUBLIC KEY-----\abcdefghijklmnopqrstuvwxyz...\n-----END PUBLIC KEY-----",
208+
Passphrase: "passphrase",
208209
},
209210
}
210211

@@ -404,8 +405,9 @@ func test_UpdateUserEntry(t *testing.T) {
404405
if !ok {
405406
t.Fatalf("Failed to get credential access code data from entry: %v", updatedCredentialAccessCodeEntry)
406407
}
408+
updatedPrivateKeyData.Username = updatedPrivateKeyData.Username + "-updated"
409+
updatedPrivateKeyData.Password = updatedPrivateKeyData.Password + "-updated"
407410
updatedPrivateKeyData.Passphrase = updatedPrivateKeyData.Passphrase + "-updated"
408-
updatedPrivateKeyData.OverridePassword = updatedPrivateKeyData.OverridePassword + "-updated"
409411
updatedCredentialPrivateKeyEntry.Data = updatedPrivateKeyData
410412

411413
updatedCredentialPrivateKeyEntry, err = testClient.Entries.Credential.Update(updatedCredentialPrivateKeyEntry)

0 commit comments

Comments
 (0)