Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move run_plan logic from cli.py into client.py #593

Open
keithralphs opened this issue Aug 15, 2024 · 0 comments
Open

Move run_plan logic from cli.py into client.py #593

keithralphs opened this issue Aug 15, 2024 · 0 comments
Labels
cli Relates to CLI code client Relates to client code good first issue Good for newcomers python Pull requests that update Python code

Comments

@keithralphs
Copy link
Contributor

cli.py should be a thin layer just to handle the commands so the legic that is currently in the run_plan method should be moved into the equivalent function it calls in client.py. This will also mean all the code is in the module where the tracing starts.
@stan-dot stan-dot added good first issue Good for newcomers python Pull requests that update Python code client Relates to client code cli Relates to CLI code labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli Relates to CLI code client Relates to client code good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keithralphs @stan-dot