Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove models that are just wrappers for lists #624

Open
DiamondJoseph opened this issue Sep 6, 2024 · 4 comments
Open

Remove models that are just wrappers for lists #624

DiamondJoseph opened this issue Sep 6, 2024 · 4 comments
Labels
python Pull requests that update Python code rest api Potential REST API changes wontfix This will not be worked on

Comments

@DiamondJoseph
Copy link
Collaborator

DeviceResponse, PlanResponse and TaskListResponse base models all just wrap a list. We could just return the list.

@callumforrester
Copy link
Collaborator

See the top answer here: https://softwareengineering.stackexchange.com/questions/286293/whats-the-best-way-to-return-an-array-as-a-response-in-a-restful-api

@stan-dot stan-dot added python Pull requests that update Python code rest api Potential REST API changes labels Sep 9, 2024
@stan-dot
Copy link
Collaborator

stan-dot commented Sep 9, 2024

petition to close as not planned @DiamondJoseph

@callumforrester
Copy link
Collaborator

I wanted to make sure this is documented in @keithralphs' service design guidelines, once I've checked I'll close this.

@stan-dot
Copy link
Collaborator

stan-dot commented Sep 9, 2024

@DiamondJoseph DiamondJoseph added the wontfix This will not be worked on label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code rest api Potential REST API changes wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants