Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the OAV to ophyd-async #716

Closed
DominicOram opened this issue Jul 29, 2024 · 3 comments · Fixed by #857
Closed

Convert the OAV to ophyd-async #716

DominicOram opened this issue Jul 29, 2024 · 3 comments · Fixed by #857

Comments

@DominicOram
Copy link
Contributor

We should try and get all our devices into ophyd-async. The OAV is one of the last ones left

Note

This is a reasonably large device, it may make sense to split it into multiple issues

Acceptance Criteria

  • The OAV is converted into ophyd-async
  • Tests all still pass
@DominicOram
Copy link
Contributor Author

#801 should be done first

@DominicOram
Copy link
Contributor Author

As part of this we should probably look at how we do the OAVConfigParams. Particularly how they get updated from the device. It may make more sense for them to be derived signals bluesky/ophyd-async#525

@noemifrisina
Copy link
Collaborator

As this is a fairly large device and we probably can't have an ophyd-async device with ophyd components (or viceversa), the first step will be to make a new very basic ophyd-async device meeting the minimum needs for i24 serial and then we can add the rest of the functionality as we go along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants