Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for zoom levels in ZoomController #884

Open
DominicOram opened this issue Nov 4, 2024 · 0 comments
Open

Remove check for zoom levels in ZoomController #884

DominicOram opened this issue Nov 4, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

In the ZoomController we currently raise a ZoomLevelNotFoundError if the zoom levels set by the user do not match the levels specified on the device. These could be different as we use a string signal but the device actually has an enum. The only purpose of this check is to give a nice exception to the user that lists the possible values that the zoom controller has. However, this behavior should probably be in ophyd-async (if it's not already).

Acceptance Criteria

  • Test what ophyd-async does if you try and set an enum with in invalid string
  • If ophyd-async responds with an error containing the actually valid strings then remove this check in dodal
  • If not add this behavior to ophyd-async
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Nov 4, 2024
@olliesilvester olliesilvester added the good first issue Good for newcomers label Nov 11, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Todo This Sprint
Development

No branches or pull requests

2 participants