Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass visit in to Hyperion directly #302

Closed
DominicOram opened this issue Dec 12, 2023 · 1 comment · Fixed by #491
Closed

Pass visit in to Hyperion directly #302

DominicOram opened this issue Dec 12, 2023 · 1 comment · Fixed by #491
Labels
good first issue Good for newcomers hyperion

Comments

@DominicOram
Copy link
Contributor

Currently the visit is guessed based on either the detector save directory or the visit_path specified in the ispyb params. Plans should instead pass in the visit itself and the visit_path should be worked out from this by Hyperion.
@DominicOram DominicOram added the good first issue Good for newcomers label Jan 11, 2024
@DominicOram DominicOram mentioned this issue Jul 18, 2024
Closed
@DominicOram
Copy link
Contributor Author

I think we do pass the visit now and the only place the directory is used is in robot load, where we immediately convert it back to a visit, we can probably remove this

@olliesilvester olliesilvester mentioned this issue Aug 22, 2024
Closed
@DominicOram DominicOram transferred this issue from DiamondLightSource/hyperion Sep 2, 2024
@DominicOram DominicOram removed their assignment Sep 2, 2024
@DominicOram DominicOram mentioned this issue Sep 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hyperion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split robot load into it's own plan DiamondLightSource/mx-bluesky
2 participants
@DominicOram @olliesilvester