Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I24 Serial: Parameter model should contain a DetectorParams #684

Open
DominicOram opened this issue Nov 27, 2024 · 0 comments · May be fixed by #708
Open

I24 Serial: Parameter model should contain a DetectorParams #684

DominicOram opened this issue Nov 27, 2024 · 0 comments · May be fixed by #708
Labels
I24 serial Issues relating to ssx on I24

Comments

@DominicOram
Copy link
Contributor

In Hyperion we call detector_params on our parameter models to give us information about the detector (see

mx-bluesky/src/mx_bluesky/common/parameters/gridscan.py

Line 39 in e710442

@property
). We should have the same interface in the i24 SSX code.

Acceptance Criteria

  • There is a detector_params property on the I24 SSX parameter model
  • Calling it returns a DetectorParams with most information filled in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I24 serial: Use DetectorParams in parameter model DiamondLightSource/mx-bluesky
2 participants
@DominicOram @noemifrisina