-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CodeQL and Sonarcloud for enhanced repo security #180
Comments
Before working on a PR to put this into copier, please try it for a reasonable period in other repos, then report back if it gives any useful results. My experience with these tools is that they make more noise than useful alerts, so I'd like to see if they have improved. |
that's very reasonable. arguably this should be an existing repo, not a new one. @coretl , @callumforrester do you have a repo candidate? maybe blueapi ? |
Be nice to prove we have it configured right on i22-bluesky, since right now the security tab isn't really giving much information. |
Yep, happy to see this added to blueapi |
will revisit this once those repos are tested for 3 months - setting this for 19.11.2024 |
considering testing for 3 months months in more repos. and also potentially the bluesky repos https://github.com/bluesky/bluesky/ https://github.com/bluesky/ophyd-async @coretl thoughts? |
@stan-dot if you're looking for a gitlab repo to try on, the NeXus service would be OK. It'll be a different setup (and Java), and I don't think we're using the copier-template for gitlab atm? |
The copier template explicitly no longer supports Gitlab AFAIK |
Feel free to add it to ophyd-async. Ignore gitlab for now. |
ok will do, can I make a PR to bluesky too? and dodal? |
I think doing it for an external repo is a different question |
https://github.com/apps/sonarcloud
https://codeql.github.com/
see the repo for reference
DiamondLightSource/i18-bluesky#20
There is a DLS precedent for the use of codeql in the python-murfey repo
UPDATE: this had also been tested in the
i18-bluesky
repositoryThe text was updated successfully, but these errors were encountered: