Merge pull request #128 from BressOne/bugfix-settings-init

Author: DianaIonita

src/apiGatewayCachingPlugin.js

@@ -41,16 +41,16 @@ class ApiGatewayCachingPlugin {
   }
 
   async updateStage() {
+    if (!this.settings) {
+      this.createSettings()
+    }
+
     this.thereIsARestApi = await restApiExists(this.serverless, this.settings);
     if (!this.thereIsARestApi) {
       this.serverless.cli.log(`[serverless-api-gateway-caching] No REST API found. Caching settings will not be updated.`);
       return;
     }
 
-    if (!this.settings) {
-      this.createSettings()
-    }
-
     return updateStageCacheSettings(this.settings, this.serverless);
   }
 

src/restApiId.js

@@ -41,8 +41,8 @@ const outputRestApiIdTo = (serverless) => {
 };
 
 const getAlreadyDeployedStack = async (serverless, settings) => {
-  const stackName = serverless.providers.aws.naming.getStackName(settings.stage);
   try {
+    const stackName = serverless.providers.aws.naming.getStackName(settings.stage);
     const stack = await serverless.providers.aws.request('CloudFormation', 'describeStacks', { StackName: stackName },
       settings.stage,
       settings.region

test/creating-plugin.js

@@ -73,7 +73,7 @@ describe('Creating plugin', () => {
         thereIsARestApi: false,
         expectedLogMessage: '[serverless-api-gateway-caching] No REST API found. Caching settings will not be updated.',
         expectedToUpdateStageCache: false,
-        expectedToHaveSettings: false
+        expectedToHaveSettings: true
       },
       {
         description: 'there is a REST API',