-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for command GEOSEARCH
#1254
Comments
Hey @arpitbbhayani |
Hi @Dev79844, Assigned. Thanks for contributing to DiceDB. |
Hi @arpitbbhayani I would like to contribute to this specific issue. Can you assign it to me too? |
@Dev79844 Any update on this ? Are you still working on this ? |
I am working on this issue. I am waiting for other geo commands like georadius to be merged as many of those functions are used in this command. |
Hello @arpitbbhayani |
I think we can easily finish this up once #1294 is merged, because they share a lot of the same code. Once this is reviewed, I'd happily take this one up. |
Add support for the
GEOSEARCH
command in DiceDB similar to theGEOSEARCH
command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the
tests
folder. Note: they have usedTCL
for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.For the command, benchmark the code and measure the time taken and memory allocs using
benchmem
and try to keep them to the bare minimum.The text was updated successfully, but these errors were encountered: