Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command GEOSEARCH #1254

Open
arpitbbhayani opened this issue Nov 7, 2024 · 7 comments
Open

Add support for command GEOSEARCH #1254

arpitbbhayani opened this issue Nov 7, 2024 · 7 comments
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the GEOSEARCH command in DiceDB similar to the GEOSEARCH command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@Dev79844
Copy link
Contributor

Dev79844 commented Nov 7, 2024

Hey @arpitbbhayani
I would like to work on this. Can you assign it to me?

@apoorvyadav1111
Copy link
Contributor

Hi @Dev79844, Assigned. Thanks for contributing to DiceDB.

@Sarthak762
Copy link

Hi @arpitbbhayani I would like to contribute to this specific issue. Can you assign it to me too?

@vpsinghg
Copy link
Contributor

vpsinghg commented Dec 2, 2024

@Dev79844 Any update on this ? Are you still working on this ?
@apoorvyadav1111 , I would like to contribute to this issue. Can you assign it to me?

@Dev79844
Copy link
Contributor

Dev79844 commented Dec 2, 2024

I am working on this issue. I am waiting for other geo commands like georadius to be merged as many of those functions are used in this command.

@Dev79844
Copy link
Contributor

Hello @arpitbbhayani
I won't be able to work on this issue for next 10-15 days due to some personal commitments. It would be great if you can assign it to someone else to maintain the momentum of the project.

@benbarten
Copy link

I think we can easily finish this up once #1294 is merged, because they share a lot of the same code. Once this is reviewed, I'd happily take this one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants