Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koushoku.yaml plugin indev adds magazine tag even if it doesn't exist in the original info.yaml file #1025

Closed
shinji257 opened this issue Jul 21, 2024 · 2 comments

Comments

@shinji257
Copy link
Contributor

shinji257 commented Jul 21, 2024

LRR Version and OS
0.9.1

Bug Details
Note: I sideload added the Ksk.pm file from dev branch as a new item with a changed name so I could test it. It only changed the name and namespace fields in the plugin_info area in order to make sure that there were no conflicts.

When tagging an info.yaml as described in a previous ticket (single line vs the older multi line) the plugin erroneously added a magazine tag even if it doesn't exist in the info.yaml file. This does not happen with the older format. The issue also technically applies to the artist and series fields as well but most info.yaml files that it would process should already have them however since it will still drop those empty tags in a info.yaml file laid out different suggests that those should be blocked if empty as well.

Matching Logs

Started Batch Operation...
************
Processed ID c28cceb4094e5f8baa4be8592a642d546060e096 with "kskyamlmeta-dev" (Added tags:  artist:, series:, magazine:)

Screenshots
Result:
image

@siliconfeces
Copy link
Contributor

I've made a PR (#1023) that should fix that issue, if you want you can try it out in my branch

@shinji257
Copy link
Contributor Author

shinji257 commented Jul 21, 2024

Thanks. I see that your PR is already merged so I pulled the copy off this repo's dev branch to sideload into 0.9.1.

Update: Yup. Seems to work fine. No blank tags to speak of.

@Difegue Difegue closed this as completed Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants